Skip to content

Update with upstream beta enableSandboxing PR #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Sep 13, 2022

Conversation

BrettCleary
Copy link
Collaborator

@BrettCleary BrettCleary commented Sep 13, 2022

Gets latest commits from Heroic-Games-Launcher/HeroicGamesLauncher#1783 (which is up to date with the Heroic-Games-Launcher/HeroicGamesLauncher/beta branch) so that we can start working with preload scripts and contextIsolation enabled.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

BrettCleary and others added 17 commits September 12, 2022 18:48
…, uncomment react devtools, exe optional parameter on Tools
fixing not permanently saving downloadNoHttps config option
* remove useEffect double import

* catch type error end of json

* Added try catch

* Add log prefix to see what runner fails
* Add codecheck to pre push and workflow

* Add new workflow for codecheck

* renaming
Copy link
Contributor

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BrettCleary BrettCleary merged commit ff8301d into main Sep 13, 2022
@BrettCleary BrettCleary deleted the update_with_upstream_beta branch September 13, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants