Humanize for DateTime? defaulting to "never" #493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "Mono.Cecil": "0.9.6.1", | ||
| "xunit": "2.1.0", | ||
| "xunit.runner.visualstudio": "2.1.0" | ||
| }, |
There was a problem hiding this comment.
@rdoubleui can you revert the changes to this file, they are irrelevant to the feature, right?
This reverts commit 0909851.
…g the desired behaviour right out of the extension method.
| @@ -1028,12 +1030,12 @@ namespace Humanizer.DateTimeHumanizeStrategy | |||
| } | |||
| public class PrecisionDateTimeHumanizeStrategy : Humanizer.DateTimeHumanizeStrategy.IDateTimeHumanizeStrategy | |||
| { | |||
| public PrecisionDateTimeHumanizeStrategy(double precision = 0.75) { } | |||
| public PrecisionDateTimeHumanizeStrategy(double precision = 0,75) { } | |||
There was a problem hiding this comment.
There is still no upstream version for this problem? :-( This line should be reverted, and 1038 also.
There was a problem hiding this comment.
Done. The PR is still pending.
There was a problem hiding this comment.
Yes :) Just saw the trouble within diff in that moment.
| @@ -34,6 +40,6 @@ public interface IFormatter | |||
| /// <param name="timeUnit"></param> | |||
| /// <param name="unit"></param> | |||
| /// <returns></returns> | |||
| string TimeSpanHumanize(TimeUnit timeUnit, int unit); | |||
| string TimeSpanHumanize(TimeUnit timeUnit, int unit); | |||
There was a problem hiding this comment.
Please remove this extra whitespace at the end of the line.
|
LGTM |
|
👍 |
clairernovotny
pushed a commit
that referenced
this pull request
Dec 8, 2015
Humanize for DateTime? defaulting to "never"
|
Need to localize for supported languages |
|
@hazzik Yes, should this be another issue? How's this to be addressed? |
|
@rdoubleui another issue. How we will handle it? - not sure yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In continuation to #479 I added the
Humanizeoverload forDateTime?.