Skip to content

fix: FIT-41: Background of Prompts Beta modal is not optimized for Dark mode #7511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2025

Conversation

yyassi-heartex
Copy link
Contributor

This pull request introduces state management improvements for the ThemeToggle component in the web/libs/ui/src/lib/ThemeToggle/ThemeToggle.tsx file. The changes integrate the jotai library to manage the theme state globally, allowing other parts of the application to access and update the theme.

State Management Enhancements:

  • Added jotai imports (atom and useSetAtom) to enable global state management for the theme.
  • Created a new themeAtom using jotai to store the current theme state globally, initialized with the result of the getCurrentTheme function.
  • Integrated useSetAtom to update the themeAtom whenever the theme changes, ensuring the global state reflects the latest theme selection. [1] [2]

Copy link

netlify bot commented May 12, 2025

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 6cae6e9
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/68224de8645e7e00086331ae

Copy link

netlify bot commented May 12, 2025

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 6cae6e9
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/68224de82bd5fd0008e7b618

@github-actions github-actions bot added the fix label May 12, 2025
Copy link

netlify bot commented May 12, 2025

Deploy Preview for label-studio-storybook ready!

Name Link
🔨 Latest commit 6cae6e9
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-storybook/deploys/68224de82c37040008001b4c
😎 Deploy Preview https://deploy-preview-7511--label-studio-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yyassi-heartex yyassi-heartex requested a review from a team May 12, 2025 14:25
@yyassi-heartex yyassi-heartex merged commit cef08e8 into develop May 12, 2025
72 of 76 checks passed
@robot-ci-heartex robot-ci-heartex deleted the fb-fit-41/theme-atom branch May 12, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants