fix: LEAP-2064: Choices on imported annotations are not displayed in View All on initial load #7488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…View All on initial load
nass600
requested review from
nick-skriabin,
hlomzik,
bmartel,
Gondragos and
yyassi-heartex
✅ Deploy Preview for label-studio-docs-new-theme ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for heartex-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
yyassi-heartex
approved these changes
May 7, 2025
hlomzik
reviewed
May 8, 2025
hlomzik
reviewed
May 8, 2025
hlomzik
approved these changes
May 8, 2025
|
/git merge
|
Gondragos
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two flags at play related with this bug:
fflag_fix_front_dev_3391_interactive_view_allfflag_fix_front_leap_443_select_annotation_onceThe issue comes from selecting "Compare all annotations" view and having the flag
fflag_fix_front_leap_443_select_annotation_onceenabled given that introduces performance improvements so we can keep the interactivity of the annotations while we do notselectall of them just the current one.Now, during the select process, control tags (
Choices,Taxonomy,Rating,DateTime,Number) values are computed so they can be rendered with the right checked/unchecked state and having this flag enabled skips this process.The fix introduces the computation of these selections based on the results when the user enters in the "Compare all annotation" mode without "selecting" them
Additionally, the PR will fix some cosmetic issues with
antdcheckboxes