Skip to content

fix: OPTIC-2093: Audio hotkeys for step back/forward missing #7426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 30, 2025
Merged

fix: OPTIC-2093: Audio hotkeys for step back/forward missing #7426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b299768
fix: OPTIC-2093: Audio hotkeys for step back/forward missing
bmartel Apr 25, 2025
78cdfad
Sync Follow Merge dependencies
MihajloHoma Apr 28, 2025
93d0e4e
Merge branch 'develop' into 'fb-optic-2093'
MihajloHoma Apr 28, 2025
3884109
Update web/libs/editor/src/tags/object/AudioUltra/view.tsx
bmartel Apr 29, 2025
37c73c7
making audio keys in a separate key namespace and applying the target…
bmartel Apr 29, 2025
16aa335
Merge remote-tracking branch 'origin/develop' into fb-optic-2093
bmartel Apr 29, 2025
88c7347
Sync Follow Merge dependencies
MihajloHoma Apr 30, 2025
3790263
Merge branch 'develop' into 'fb-optic-2093'
MihajloHoma Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions web/libs/editor/src/core/settings/keymap.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,14 @@
"mac": "command+p",
"description": "Play/pause"
},
"audio:step-backward": {
"key": "alt+a",
"description": "Go one step back"
},
"audio:step-forward": {
"key": "alt+d",
"description": "Go one step forward"
},
"ts:grow-left": {
"key": "left",
"description": "Increase region to the left"
Expand Down
2 changes: 2 additions & 0 deletions web/libs/editor/src/tags/object/AudioUltra/view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,8 @@ const AudioUltraWithSettings: FC<AudioUltraProps> = ({ item }) => {
// @todo this hotkey should be moved from these settings for a more appropriate place;
// @todo we are planning to have a central hotkeys management, that would be a better option.
playpauseHotkey: "audio:playpause",
stepBackHotkey: "audio:step-backward",
stepForwardHotkey: "audio:step-forward",
loopRegion: false,
autoPlayNewSegments: true,
});
Expand Down
Loading