Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSAnimationEnd does not work in IE 11, but animationend does #242

Closed
vapalamar opened this issue Sep 27, 2017 · 7 comments
Closed

MSAnimationEnd does not work in IE 11, but animationend does #242

vapalamar opened this issue Sep 27, 2017 · 7 comments

Comments

@vapalamar
Copy link

vapalamar commented Sep 27, 2017

This event should occur when we close modal window. But it doesn't, so, as the result, the modal window is not closed. What if we always add an event listener for the animationend event? Or there is another fix? Attached version of IE.

image

@bbatliner
Copy link
Contributor

bbatliner commented Sep 27, 2017

So animationEndEvent/detectAnimationEndEvent exists now to detect the correct animation end to use. Are you saying this doesn't work in that version of IE?

@vapalamar
Copy link
Author

vapalamar commented Sep 27, 2017

@bbatliner Yes, animationEndEvent/detectAnimationEndEvent returns MSAnimationEnd in this version of Internet Explorer, and this isn't working. However, if we return animationend string from this method instead, everything will work as expected.

@vapalamar
Copy link
Author

vapalamar commented Sep 27, 2017

I opened the pull request with a possible fix:
#243

@PixievoltNo1
Copy link
Contributor

When I made Pull Request #238, in the process the animation properties got rearranged to put the unprefixed property last. When browsers encounter both prefixed and unprefixed versions of a property, they apply a "last one wins" rule. Since detectAnimationEndEvent uses a "first one wins" rule, animation should be tested for first to match that behavior. #243 doesn't change that; if you like, I can make a different pull request and we'll see if it fixes the problem.

@vapalamar
Copy link
Author

@PikadudeNo1 got it. It would be really nice if you create a pull request with a possible fix.

@PixievoltNo1
Copy link
Contributor

I just tested this by running the grunt command and opening test/build-test.html in IE - vexes seem to be closing properly and everything seems to be working OK, no code changes needed. IE version 11.674.15063.0.

bbatliner added a commit that referenced this issue Feb 24, 2018
@bbatliner
Copy link
Contributor

bbatliner commented Feb 24, 2018

I switched the order of the property checks so that animation is checked first. Should work better in modern browsers with no change for older ones. This'll be published with the next release which I'll get to this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants