Skip to content

feat: Add 2025.2 style components #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

feat: Add 2025.2 style components #46

wants to merge 32 commits into from

Conversation

joe-yeager
Copy link
Contributor

@joe-yeager joe-yeager commented Jun 17, 2025

Begins to split components up by platform version. Keeps the legacy components in their current position for backwards compatibility

},
{
"name": "getting-started-public-app",
"label": "CRM getting started project with public apps",
"path": "projects/public-app-getting-started-template",
"insertPath": "./"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

insertPath was only ever set to ./, so it was essentially a noop, so I removed it.

@joe-yeager joe-yeager marked this pull request as ready for review June 17, 2025 23:25
@@ -0,0 +1,60 @@
{
"defaultFiles": "./defaultFiles",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the CLI downloading the defaultFiles directory automatically, so anything we want to get auto downloaded can go in there.

Comment on lines +4 to +24
{
"label": "Static Private App",
"type": "app",
"authType": "static",
"distribution": "private",
"path": "components/app/static-private"
},
{
"label": "OAuth Private App",
"type": "app",
"authType": "oauth",
"distribution": "private",
"path": "components/app/oauth-private"
},
{
"label": "OAuth Marketplace App",
"type": "app",
"authType": "oauth",
"distribution": "marketplace",
"path": "components/app/oauth-marketplace"
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was easier to split these up than have the CLI tried to do some sort of auto-generation

Comment on lines +32 to +33
"supportedAuthTypes": ["oauth", "static"],
"supportedDistributions": ["private", "marketplace"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use these supported options to determine which components are valid options on create and add

Copy link
Contributor

@camden11 camden11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (pending any changes on the CLI side)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants