-
Notifications
You must be signed in to change notification settings - Fork 8
feat: Add 2025.2 style components #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
}, | ||
{ | ||
"name": "getting-started-public-app", | ||
"label": "CRM getting started project with public apps", | ||
"path": "projects/public-app-getting-started-template", | ||
"insertPath": "./" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
insertPath
was only ever set to ./
, so it was essentially a noop, so I removed it.
@@ -0,0 +1,60 @@ | |||
{ | |||
"defaultFiles": "./defaultFiles", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the CLI downloading the defaultFiles
directory automatically, so anything we want to get auto downloaded can go in there.
{ | ||
"label": "Static Private App", | ||
"type": "app", | ||
"authType": "static", | ||
"distribution": "private", | ||
"path": "components/app/static-private" | ||
}, | ||
{ | ||
"label": "OAuth Private App", | ||
"type": "app", | ||
"authType": "oauth", | ||
"distribution": "private", | ||
"path": "components/app/oauth-private" | ||
}, | ||
{ | ||
"label": "OAuth Marketplace App", | ||
"type": "app", | ||
"authType": "oauth", | ||
"distribution": "marketplace", | ||
"path": "components/app/oauth-marketplace" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was easier to split these up than have the CLI tried to do some sort of auto-generation
"supportedAuthTypes": ["oauth", "static"], | ||
"supportedDistributions": ["private", "marketplace"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use these supported options to determine which components are valid options on create
and add
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (pending any changes on the CLI side)
Begins to split components up by platform version. Keeps the legacy components in their current position for backwards compatibility