Add hubapi override #638
Merged
Add hubapi override #638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 28, 2022 12:34
packages/cli-lib/lib/urls.js
Outdated
| return `https://${useLocalHost ? 'local' : 'api'}.hubapi${getEnvUrlString( | ||
| env | ||
| )}.com`; | ||
| var domain = process.env.HUBAPI_DOMAIN_OVERRIDE; |
There was a problem hiding this comment.
nit, but this supports es6 syntax so you can use let here.
brandenrodgers
approved these changes
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
We want to be able to override which HubAPI domain to hit via environment variable. Fall back on the existing logic if it's unset