Project watch: watch for deleted directories #637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/cli-lib/projectsWatch.js
Outdated
| 'deleteFile' | ||
| ); | ||
| }); | ||
| watcher.on('unlinkDir', async filePath => { |
There was a problem hiding this comment.
kind of a nit, but should this arg be folderPath?
packages/cli-lib/projectsWatch.js
Outdated
| ); | ||
| }); | ||
| watcher.on('unlinkDir', async filePath => { | ||
| addFile( |
There was a problem hiding this comment.
Not a blocker, but this func supports folders and also the "delete" action now. I wonder if we should change the name of it to be more generic.
brandenrodgers
approved these changes
Jan 28, 2022
|
Thanks @brandenrodgers, renamed a couple things based on your feedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
project watchwas previous only watching for directories. This updates the watcher to include directories and hit the same delete endpoint.Screenshots
TODO
Who to Notify