Skip to content

Update dependencies to remove vulnerabilities #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 3, 2021

Conversation

miketalley
Copy link
Contributor

@miketalley miketalley commented Nov 29, 2021

Description and Context

Updating dependencies to remove vulnerabilities as referenced in #593

spinnies contains a vulnerability that was added since 0.3.2 (current version is 0.5.1). Since we rely on some functionality that has been added, we will leave this version for now and see if we can get a PR to fix the issue in the spinnies repo.

Lerna contains most of the remaining vulnerabilities, but has not been updated since 4.0.0, which we are using. There is an issue to update the dependencies to remove vulnerabilities, which is promising.

Screenshots

Output of yarn audit before this PR
image

Output of yarn audit after this PR
image

TODO

  • Create a PR for spinnies to fix the vulnerability in their deps @anthmatic
  • Keep an eye on new releases of lerna that include updated dependencies
  • Discuss upgrade path to node >= 12

Who to Notify

@arinker @gcorne @brandenrodgers @kemmerle

@brandenrodgers
Copy link
Contributor

This all lgtm aside from the issue with spinnies.remove

@miketalley miketalley merged commit ccf33c6 into master Dec 3, 2021
@miketalley miketalley deleted the hotfix/fix-vulnerabilities branch December 3, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants