Add util for getting account description #592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandenrodgers
approved these changes
Nov 10, 2021
anthmatic
commented
Nov 16, 2021
| module.exports = { | ||
| link, | ||
| getAccountDescription, | ||
| }; |
There was a problem hiding this comment.
@brandenrodgers I requested another review because I thought it might make sense to pull these "ui" related utils together in the CLI package but wanted to get your 👍 first
brandenrodgers
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
An alternative to #575. This PR achieves the same goal of displaying
Account Name (Account ID)but can be called anywhere thataccountIdis known and eliminates the need to pass around theaccountDescriptionvariableThis also introduces
cli/lib/uifor CLI UI related utilsScreenshots
TODO
Who to Notify