Fix bug while tailing logs for new function #590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -63,7 +63,7 @@ const endpointLog = async (accountId, options) => { | |||
| getFunctionLogs(accountId, functionPath, { after }); | |||
| const fetchLatest = () => { | |||
| try { | |||
| getLatestFunctionLog(accountId, functionPath); | |||
| return getLatestFunctionLog(accountId, functionPath); | |||
There was a problem hiding this comment.
Seems reasonable, do we need to return in the catch as well?
There was a problem hiding this comment.
Doubled checked with @miketalley on this: I believe the intent is for polling to continue and handleLogsError() simply logs an error as a side effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
An unexpected API error is displayed if you run
hs logs <route> --followwon a function that has no log data / previous executionsScreenshots
TODO
Who to Notify