Skip to content

Adding process exits to upload command #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

brandenrodgers
Copy link
Contributor

Description and Context

This adds a process.exit() to the end of the project upload command. It will make it so consuming systems like the GH upload action can act accordingly when uploads fail.

This will exit with process.exit(1) when:

  • Build status is "FAILURE"
  • Deploy status is "FAILURE" (if autodeploy is enabled)

Everything else will exit with process.exit(0)

Screenshots

TODO

Who to Notify

@anthmatic
Copy link
Contributor

LGTM! I am wondering, does it make sense to have all commands explicitly exit with a code?

@brandenrodgers
Copy link
Contributor Author

does it make sense to have all commands explicitly exit with a code?

@anthmatic are there any other ones you had in mind? I think it is best practice to have all commands exit with a code (but I could be wrong about that). I'm actually attempting to help standardize the exit codes here.

@brandenrodgers brandenrodgers merged commit ab85775 into master Nov 3, 2021
@brandenrodgers brandenrodgers deleted the add-process-exits-to-project-upload branch November 3, 2021 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants