Skip to content

Improve UX of project logs subcommand #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 2, 2021
Merged

Conversation

gcorne
Copy link
Contributor

@gcorne gcorne commented Nov 1, 2021

Description and Context

This PR makes the following improvements to hs project logs:

  1. Leverage hsproject.json to determine the project name when command is run inside a project directory if --projectName is not passed
  2. Remove --overwrite options from all hs project commands. The option is not relevant.
  3. Improve documentation. Don't hide --appPath and --projectName from help and make clear that the function name is an "app function."

Who to Notify

@miketalley @anthmatic @brandenrodgers

This also helps to make all project commands more consistent.
Copy link
Contributor

@brandenrodgers brandenrodgers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@gcorne gcorne merged commit c2f4644 into master Nov 2, 2021
@gcorne gcorne deleted the improve-project-logs branch November 2, 2021 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants