Skip to content

Fix bug where CLI appears to hang when build fails #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2021
Merged

Fix bug where CLI appears to hang when build fails #583

merged 1 commit into from
Oct 29, 2021

Conversation

anthmatic
Copy link
Contributor

Description and Context

Currently when polling for project status, when a build fails the CLI continues to look for a deployId, which results in the CLI appearing to hang.

This updates the check to skip the check for deploy Id on FAILURE

Screenshots

TODO

Who to Notify

@anthmatic anthmatic changed the title break up completion checks Fix bug where CLI appears to hang when build fails Oct 29, 2021
brandenrodgers
brandenrodgers approved these changes Oct 29, 2021
View reviewed changes
Copy link
Contributor

@brandenrodgers brandenrodgers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬 I think I had initially suggested the broken logic here. Thanks for finding/fixing!

@anthmatic anthmatic merged commit c821433 into master Oct 29, 2021
@anthmatic anthmatic deleted the fix/project-status-complete-check branch October 29, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandenrodgers brandenrodgers brandenrodgers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anthmatic @brandenrodgers