Add flag to forcefully create project on upload #577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandenrodgers
commented
Oct 22, 2021
anthmatic
approved these changes
Oct 22, 2021
brandenrodgers
commented
Oct 22, 2021
| @@ -218,6 +212,12 @@ exports.builder = yargs => { | |||
| type: 'string', | |||
| }); | |||
|
|
|||
| yargs.option('forceCreate', { | |||
| describe: 'Automatically create project if it does not exist', | |||
There was a problem hiding this comment.
@markhazlewood any thoughts on the name of the flag and/or the description of the flag here? I don't picture users utilizing this flag much, but it should be helpful in situations where this command is run from within another service (the GH upload action, for example).
Right now it is hs project upload --forceCreate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
Adding a flag to bypass the "do you want to create this project" question that we ask users on initial project upload. This will be used in the GH project upload action.
This is the question that this flag bypasses:
? The project example-project does not exist in 123456. Would you like to create it? YesExample usage:
hs project upload --forceCreateScreenshots
TODO
Who to Notify