Exit 2 on FATAL marketplace validations #565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should do the same in https://github.com/HubSpot/hubspot-cli/blob/master/packages/cli/commands/lint.js#L60. I also think it would be valuable to start using named constants for the exit codes to help with understandability but that is probably a good followup for someone working day-to-day on the CLI. |
I can follow this PR up with something like this 👍 @KatzMitch this is OK to merge |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
This PR updates the exit code to
2(instead of1) when the CLI has FATAL validation warnings. This will allow us to determine on the BE caller whether we are exiting because of a validation failure or because of an internal error of some other sortScreenshots
Before
After
TODO
n/a
Who to Notify
n/a