Safer copy logging POC #1473
Merged
Safer copy logging POC #1473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camden11
requested review from
brandenrodgers,
kemmerle and
joe-yeager
as code owners
kemmerle
reviewed
Apr 30, 2025
lib/projects/buildAndDeploy.ts
Outdated
| `${statusStrings.SUBTASK_FAIL( | ||
| failedSubtasks.length === 1 | ||
| ? getSubtaskName(failedSubtasks[0]) | ||
| : failedSubtasks.length + ' components', | ||
| displayId | ||
| )}\n` | ||
| ); | ||
| logger.log('See below for a summary of errors.'); | ||
| uiLogger.log('See below for a summary of errors.'); |
There was a problem hiding this comment.
Add this to the lang file?
kemmerle
reviewed
Apr 30, 2025
lib/projects/config.ts
Outdated
| @@ -61,7 +61,7 @@ export async function getProjectConfig( | |||
| projectConfig, | |||
| }; | |||
| } catch (e) { | |||
| logger.error('Could not read from project config'); | |||
| uiLogger.error('Could not read from project config'); | |||
brandenrodgers
previously approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
This creates a new typed
uiLoggerthat will help prevent lang errors. TheuiLoggeris meant to be used when logging anything from the new lang objects. It only accepts strings, so it'll catch accidentalundefinedand uncalled functions. This also updates all files that use the new lang objects to useuiLogger. It's already caught a few errors!Who to Notify
@brandenrodgers @kemmerle @joe-yeager