Organize lib/projects and use lang objects #1465
Conversation
camden11
requested review from
brandenrodgers,
kemmerle and
joe-yeager
as code owners
| @@ -1122,8 +1128,8 @@ export const commands = { | |||
| failedToFetchProjectDetails: | |||
| 'There was an error fetching project details', | |||
| noFunctionsLinkText: 'Visit developer docs', | |||
| noFunctionsInProject: link => | |||
| `There aren't any functions in this project\n\t- Run ${chalk.orange('hs project logs --help')} to learn more about logs\n\t- ${link} to learn more about serverless functions`, | |||
There was a problem hiding this comment.
Haha you beat me to it, I saw that cursor made up the chalk.orange function 🤦
There was a problem hiding this comment.
Haha cursor making things up was a common theme in this PR
|
@joe-yeager Just noticed you inlining |
@camden11 yeah, I started out just converting the the function calls, and then I realized I can just move most of them to inline calls. I think we could start small as well, just start by leaving them as variables and then slowly move them over. Up to you if you want to do it as part of this PR. |
|
Yeah, I just went ahead and did it for |
Description and Context
The upcoming work to support the Local Dev UI will require a lot of additions to the
lib/projectsfolder, so I figured now would be a good time to clean things up there a bit. This PR makes a variety of housekeeping changes/libinto `lib/projects/localDev``localDevrenamed tohelpersLocalDevManagerandLocalDevManagerV2DevServerManagerandDevServerManagerV2lib/projects/indexsince it wasn't actually an index filelib/projects/configensureProjectExistsmoved tolib/projects/ensureProjectExistslogFeedbackMessagemoved tolib/projects/uiTODO
Due to file renaming, some files lang keys no longer match their file names. I didn't want to do even more in this PR, so we can update that at a later time if it ever becomes a problem
Who to Notify
@brandenrodgers @kemmerle @joe-yeager