feat: Migrations polish #1455
Merged
feat: Migrations polish #1455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-yeager
requested review from
brandenrodgers,
camden11 and
kemmerle
as code owners
joe-yeager
commented
Apr 17, 2025
lib/app/migrate.ts
Outdated
| @@ -179,21 +179,30 @@ async function selectAppToMigrate( | |||
| if (migratableComponents.length !== 0) { | |||
| logger.log( | |||
| lib.migrate.componentsToBeMigrated( | |||
| `\n - ${migratableComponents.join('\n - ')}` | |||
| `\n - ${[...new Set(migratableComponents)].join('\n - ')}` | |||
There was a problem hiding this comment.
These need to be deduped before we log them
There was a problem hiding this comment.
Do dupes exist when the user has multiple instances of a given component? Like multiple cards?
There was a problem hiding this comment.
Yeah, they can have multiple cards, webhooks, etc.
joe-yeager
commented
Apr 17, 2025
Comment on lines
+201
to
+203
| const promptMessage = projectConfig?.projectConfig | ||
| ? `${lib.migrate.projectMigrationWarning} ${lib.migrate.prompt.proceed}` | ||
| : lib.migrate.prompt.proceed; |
There was a problem hiding this comment.
If the migration is for a project, add the project warning prefix
joe-yeager
commented
Apr 17, 2025
Comment on lines
+257
to
+267
| const { projectExists } = await ensureProjectExists( | ||
| derivedAccountId, | ||
| input, | ||
| { allowCreate: false, noLogs: true } | ||
| ); | ||
|
|
||
| if (projectExists) { | ||
| return lib.migrate.errors.project.alreadyExists(input); | ||
| } | ||
|
|
||
| return true; |
There was a problem hiding this comment.
This is fixing an issue where if the project name was already taken, we just killed the process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
Does the following: