Fix bug with hs account auth
#1450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kemmerle
requested review from
brandenrodgers,
camden11 and
joe-yeager
as code owners
| @@ -76,6 +76,15 @@ export async function loadConfigMiddleware( | |||
| } | |||
| }; | |||
|
|
|||
| if ( | |||
There was a problem hiding this comment.
Could we add this to the existing SKIP_CONFIG_VALIDATION object? I don't remember exactly how that works, but it seems like the same use case as this.
There was a problem hiding this comment.
hs account auth is a special exception, because we want to validate the config if it exists (ie. if we're just authorizing a new account). If it doesn't exist (ie. we're running the command for the first time to create the config), we don't want to validate the config, which is what this conditional stipulates.
There was a problem hiding this comment.
Ah ok, thanks. Makes sense 👍
brandenrodgers
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
Joe Kurien reported a bug that
hs account authreturns an error when no global config file is present (ie. running the command for the first time).Screenshots
BEFORE:
AFTER:
TODO
Who to Notify
@brandenrodgers @camden11 @joe-yeager