Skip to content

Log upload warning for all component configs #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 8, 2025

Conversation

camden11
Copy link
Contributor

@camden11 camden11 commented Apr 7, 2025

Description and Context

This makes a few improvements to support new component types in hs project dev

  • Upload warning is now logged when any component config is changed. Previously, it was only logged when app and card configs were changed.
  • Similarly, the warning that is logged when you have components locally that aren't in the deployed build looks for all component types, not just apps and cards.
  • Updates the copy to remove references to "public" and "production" apps

Screenshots

Screenshot 2025-04-07 at 3 56 19 PM

TODO

  • This functionality is really only a temporary fix - ideally, the dev servers should either handle this logging or tell the CLI what components they know how to handle. This will work well with the current state of unified apps, though, and is better than not logging at all.
  • Need to release project-parsing-lib

Who to Notify

@brandenrodgers @kemmerle @joe-yeager

@@ -64,7 +62,6 @@ class DevServerManagerV2 {
if (serverInterface.setup) {
await serverInterface.setup({
components: projectNodes,
onUploadRequired,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now, the only way to log the upload warning for components without dev servers is to do it from the CLI. To keep things simple, I decided to have the CLI handle the logging for UI extensions as well. From what I could tell, there was no additional logging logic in the dev server - it just checks if the changed file is a config file and then calls the logging function passed from the CLI

It will probably make sense to revisit this in the future

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should let the uie team know, but that sounds reasonable to me 👍

@camden11 camden11 merged commit 8c2df69 into main Apr 8, 2025
1 check passed
@camden11 camden11 deleted the unified-app-upload-warning branch April 8, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants