Bug fix: allow creation of projects in CWD + non project folders #1413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camden11
requested review from
brandenrodgers,
kemmerle and
joe-yeager
as code owners
joe-yeager
approved these changes
Mar 31, 2025
kemmerle
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
See https://git.hubteam.com/HubSpot/hubspot-cli-issues/issues/804
Previously, the
hs project createdest prompt didn't allow you to create a project in any existing folder (including your current working directory) and displayed an error message sayingThere is an existing project at this destination. Please provide a new path for this project.whether a project existed there or now. This updates the prompt to actually check for anhsproject.jsonfile rather than just an existing dir. This allows users to create a project in their CWD or another non-project folder via the prompt. Now, entering a dest via the prompt and entering a dest via the--destflag have matching behavior.Screenshots
The error that existed previously.
Who to Notify
@brandenrodgers @kemmerle @joe-yeager @j0b0sapi3n