feat: Add hs app migrate command
#1406
Conversation
joe-yeager
changed the title
hs app migrate command and hs project migrate command
joe-yeager
changed the title
hs app migrate command and hs project migrate commandhs app migrate command
joe-yeager
requested review from
brandenrodgers,
camden11 and
kemmerle
as code owners
| process.exit(EXIT_CODES.ERROR); | ||
| } | ||
|
|
||
| await trackCommandMetadataUsage( |
There was a problem hiding this comment.
I'm not sure what the best way to do this would be, but it might be nice to be able to differentiate between this new migration and the soon-to-be-deprecated one in our tracking
There was a problem hiding this comment.
Yeah, maybe I could add a tracking to the hs project migrate-app handler that is like migrate-app-deprecated? That seems kind of gross, but we can at least subtract those from the migrate-app total and get an idea.
There was a problem hiding this comment.
Yeah something like that could work. You could also call this one app-migrate and differentiate that way
There was a problem hiding this comment.
But the more I think about it. Maybe it's not really important to differentiate. I'm not sure if we'd even need that info
There was a problem hiding this comment.
Gotcha, I'll leave it alone as is. Actually in hindsight, we are going to deprecate and delete hs project migrate-app so once we release the next major we will only have hs app migrate
| projectName?: string; | ||
| } | ||
|
|
||
| export interface MigratableApp extends BaseMigrationApp { |
There was a problem hiding this comment.
Should these go in the types/ folder?
There was a problem hiding this comment.
I left them here because we don't really seem to have a hard a fast rule for putting them in the types/ folder. We seem to have types living in files next to the methods that use them as return types, so I went this that approach since they don't really make sense as standalone types.
There was a problem hiding this comment.
That being said I don't have a strong opinion and if we want to move this to types LMK and I will move them in a follow up, going to merge this as is.
Description and Context
This PR does the following:
hs project migrate-appandhs project clone-apphs project migrate-appcommand to a new commandhs app migrate--platform-versionflag to both commands that when added migrates the app to revamped APITesting steps
hs app migrate --platform-version unstable