-
Notifications
You must be signed in to change notification settings - Fork 67
Porting top-level commands to TS (auth and filemanager) #1401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
commands/auth.ts
Outdated
'auth', | ||
authType, | ||
TRACKING_STATUS.ERROR, | ||
providedAccountId! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this use the account that was just authed if account id wasn't provided?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We likely won't have it because this case gets hit whenever something in the try/catch goes wrong. If this gets hit, it's very likely that the config was never updated with the new id
commands/init.ts
Outdated
'init', | ||
authType, | ||
TRACKING_STATUS.STARTED, | ||
providedAccountId! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here with using the account you attempted to auth
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we can do this because we won't know the account ID until the request for the access token comes back. We'll only know it if the user passes in a providedAccountId
. So in most cases this will be undefined, but I figured it might be nice to pass it in whenever it does exist. Not sure how much value we'll get out of it though 🤷
Description and Context
Ports these files to TS:
Screenshots
TODO
Who to Notify