Skip to content

chore: Tagless experimental releases #1394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Mar 12, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions scripts/release.ts
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,11 @@ async function handler({

logger.log();
logger.log(`Updating version to ${newVersion}...`);
await exec(`yarn version --new-version ${newVersion}`);
if (isExperimental) {
await exec(`yarn version --no-git-tag-version --new-version ${newVersion}`);
} else {
await exec(`yarn version --new-version ${newVersion}`);
}
logger.success('Version updated successfully');

logger.log();
Expand Down Expand Up @@ -308,10 +312,20 @@ async function handler({
process.exit(EXIT_CODES.SUCCESS);
}

logger.log();
logger.log(`Pushing changes to Github...`);
await exec(gitCommand);
logger.log(`Changes pushed successfully`);
if (isExperimental) {
logger.log();
logger.log(`Experimental release: Skipping push to Github`);

// Reset the version back to the local version
await exec(
`yarn version --no-git-tag-version --new-version ${localVersion}`
);
Comment on lines +320 to +322
Copy link
Contributor Author

@joe-yeager joe-yeager Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't reset this back to the localVersion the version change will still be in the package.json

} else {
logger.log();
logger.log(`Pushing changes to Github...`);
await exec(gitCommand);
logger.log(`Changes pushed successfully`);
}

logger.log();
logger.success(`HubSpot CLI version ${newVersion} published successfully`);
Expand Down