Convert project dev command to ts #1387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camden11
requested review from
brandenrodgers,
kemmerle and
joe-yeager
as code owners
commands/project/dev.ts
Outdated
| authCommand: uiCommandReference('hs auth'), | ||
| }) | ||
| ); | ||
| process.exit(EXIT_CODES.SUCCESS); |
There was a problem hiding this comment.
Should this be an error?
types/Projects.ts
Outdated
| @@ -127,3 +128,10 @@ export type Component<T = GenericComponentConfig> = { | |||
| runnable: boolean; | |||
| path: string; | |||
| }; | |||
|
|
|||
| export type ProjectDevTargetAccountPromptResponse = { | |||
There was a problem hiding this comment.
Should this live in the prompt file instead?
There was a problem hiding this comment.
I couldn't decide between the two, but if you vote for prompts lets go with that
brandenrodgers
previously approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
Wanted to have everything in TS before getting started on the work for unified apps local dev. This file honestly probably needs a complete re-write so this is more of a temporary bandaid solution to get all of the types working. In any case I think it'll make working on this file a little easier
Who to Notify
@brandenrodgers @kemmerle @joe-yeager