chore: Convert filemanager commands to TypeScript
#1384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kemmerle
requested review from
brandenrodgers,
camden11 and
joe-yeager
as code owners
joe-yeager
previously approved these changes
Feb 18, 2025
| jest.mock('yargs'); | ||
| jest.mock('../../../lib/commonOpts'); | ||
|
|
||
| // Import this last so mocks apply |
There was a problem hiding this comment.
Nit: I see we have been adding this comment to the tests, but jest should be hoisting all of the jest.mock function calls to before the imports, so the actual order is irrelevant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
In this PR, I've converted the
filemanagercommands to TypeScript and added basic tests.Commands
Bucket
TODO
Who to Notify
@brandenrodgers @camden11 @joe-yeager