chore: Convert sandbox commands to TypeScript
#1383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kemmerle
requested review from
brandenrodgers,
camden11 and
joe-yeager
as code owners
camden11
reviewed
Feb 14, 2025
kemmerle
changed the title
sandbox commands to TypeScriptsandbox commands to TypeScript
joe-yeager
reviewed
Feb 18, 2025
commands/sandbox/delete.ts
Outdated
| @@ -195,6 +203,7 @@ export async function handler( | |||
| logger.error( | |||
| i18n(`${i18nKey}.failure.invalidKey`, { | |||
| account: uiAccountDescription(parentAccountId), | |||
| authCommand: uiCommandReference('hs auth personalaccesskey'), | |||
There was a problem hiding this comment.
I think this would just be hs auth since personalaccesskey is the default (and it gets passed in via option if you want to manually set it)
brandenrodgers
previously approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
In this PR, I've converted the
sandboxcommands to TypeScript and added basic tests. I also corrected the names on thehubdbandsecrettests which I wrote in previous PRs.Commands
sandbox/create.tssandbox/delete.tsBucket
sandbox.tsTODO
Who to Notify
@brandenrodgers @camden11 @joe-yeager