Add support for remembering a user's 2FA session in a cookie #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the gem store a signed cookie for a configurable amount of time that allows the user to bypass 2FA. Our use-case for this is that we expire user’s Devise sessions after 12 hours, but don’t want to force them to authenticate using 2FA every day. Signed cookies are available since Rails 3. This requires the signing functionality to be properly configured, but is disabled by setting the config variable to `0`, the default.
boffbowsh
force-pushed
the
rememberable-tfa
branch
from
3243180 to
8d4da3b
Compare
|
Any thoughts on this, @Houdini? |
Houdini
added a commit
that referenced
this pull request
Sep 8, 2015
Add support for remembering a user's 2FA session in a cookie
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the gem store a signed cookie for a configurable amount of
time that allows the user to bypass 2FA. Our use-case for this is that
we expire user’s Devise sessions after 12 hours, but don’t want to
force them to authenticate using 2FA every day.
Signed cookies are available since Rails 3. This requires the signing
functionality to be properly configured, but is disabled by setting the
config variable to
0, the default.