Skip to content

you-get: migrate to [email protected] #62229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

gaurdro
Copy link
Contributor

@gaurdro gaurdro commented Oct 7, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@BrewTestBot BrewTestBot added missing license Formula has a missing license which should be added python Python use is a significant feature of the PR or issue labels Oct 7, 2020
@BrewTestBot BrewTestBot removed the missing license Formula has a missing license which should be added label Oct 7, 2020
@Rylan12
Copy link
Member

Rylan12 commented Oct 7, 2020

Thanks for working on this, @gaurdro. We really appreciate it.

If you don't mind, can you hold off on opening these until the virtualenv fix gets merged? I just don't want to waste CI capacity on things that we expect to fail.

I've seen a few that have passed, though, and those are totally fine!

Edit: ooh, you get bonus points for adding the license! 😄

@gaurdro
Copy link
Contributor Author

gaurdro commented Oct 7, 2020

@Rylan12 of course! I've been trying to only make PRs for ones that don't use a virtualenv, this one I missed because it happened to work locally.

@fxcoudert
Copy link
Member

I'm re-running CI, to check the virtualenv fix at Homebrew/brew#8873
Even if CI is green, this should not be merged before the next Brew tag ships, expected on Monday 2020-10-12.

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Python use is a significant feature of the PR or issue python-3.9-migration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants