nlohmann-json: 3.6.1 (new formula) #38257
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Optional dependencies are not acceptable in homebrew-core. I'd suggest just using cmake support. |
Replaced optional dependencies with build dependencies according to Homebrew#38257
|
You can drop the caveat now that there's no options anymore. And I don't think all the explanation in the test is required. Other maintainers might disagree though. |
Removed redundant caveats. Keeping verbose test case for now.
|
Ah… my bad 🤦♂️ |
SMillerDev
approved these changes
Mar 26, 2019
fxcoudert
requested changes
Mar 26, 2019
JarryShaw
commented
Mar 27, 2019
|
@JarryShaw I don't think you've pushed your changes to the test, they do not appear |
Simplified tests based on review per @fxcoudert
Sorry again 🤦♂️ not familiar with this GitHub feature |
Ahhhhhhhhh… so this time it should work :)
fxcoudert
approved these changes
Apr 18, 2019
|
Thanks @JarryShaw this is looking good! |
fxcoudert
added
ready to merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nlohmann/jsonis a (seems) wildly used JSONlibrary for C++. The formula is directly migrated
from this Tap.
See: https://github.com/nlohmann/json