Skip to content

sloc 0.2.1 (new formula) #35632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

sloc 0.2.1 (new formula) #35632

wants to merge 3 commits into from

Conversation

JarryShaw
Copy link
Contributor

sloc is a simple tool to count SLOC (source lines of code) implemented in Node.js, which is kind of similar to cloc (another SLOC tool implemented in Perl).

  • The main formula is generated using noob.
  • The test part is inspired from the formula of cloc.

@JarryShaw
sloc 0.2.1 (new formula)
3b6b60f 
`sloc` is a simple tool to count SLOC (source lines of code)
implemented in Node.js, which is kind of similar to `cloc`
(a SLOC tool implemented in Perl).
@fxcoudert fxcoudert added the new formula PR adds a new formula to Homebrew/homebrew-core label Jan 2, 2019
@fxcoudert
Copy link
Member

fxcoudert commented Jan 2, 2019 •
edited
Loading 

sloc:
  * C: 4: col 9: Description should start with a capital letter
  * C: 4: col 9: Description shouldn't start with the formula name
  * C: 26: col 1: Use 2 spaces for indentation in a heredoc.
  * Stable: version 0.2.1 is redundant with version scanned from URL

Otherwise looking good!

@fxcoudert fxcoudert added the almost there PR is nearly ready to merge label Jan 2, 2019
@JarryShaw
sloc: fix for PR audit
1e5c31a 
 - revised description (C: 4: col 9)
 - updated indentation for heredoc (C: 26: col 1)
 - removed redundant version
@JarryShaw
sloc: fix for PR audit (round 2)
4f0298a 
 - revised description (C: 4: col 9, C: 4: col 52)
@JarryShaw
Copy link
Contributor Author

JarryShaw commented Jan 3, 2019 •
edited
Loading

Finally, all tests passed :)

ps: my Mac has problems with brew audit and brew tests; Issue just filed, hopefully it will help :(

@fxcoudert fxcoudert added ready to merge PR can be merged once CI is green and removed almost there PR is nearly ready to merge labels Jan 3, 2019
@fxcoudert
Copy link
Member

@JarryShaw please squash all changes into a single commit, with commit message sloc 0.2.1 (new formula), so we can merge this

@JarryShaw
Copy link
Contributor Author

Sorry but I seem to have some trouble w/ that ☹️ @fxcoudert can't u just squash and commit from GitHub?

@fxcoudert
Copy link
Member

We don't commit from Github because of the bottles. But I'll do it manually, then.

@fxcoudert
Copy link
Member

Thanks @JarryShaw for the pull request!

@fxcoudert fxcoudert closed this in f0fb02e Jan 3, 2019
@lock lock bot added the outdated PR was locked due to age label Feb 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fxcoudert fxcoudert fxcoudert approved these changes

Assignees
No one assigned
Labels
new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JarryShaw @fxcoudert