Skip to content

Ghidra 11.3.2 (new formula) #226642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Tokarak
Copy link

@Tokarak Tokarak commented Jun 12, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?
  * line 5, col 3: `url` (line 5) should be put before `version` (line 4)
  * line 27, col 119: Line is too long. [124/118]
  * The homepage URL https://www.nsa.gov/ghidra is not reachable (HTTP status code 403)
  * Stable: version 11.3.2 is redundant with version scanned from URL
  * Binaries built for a non-native architecture were installed into ghidra's prefix.
    The offending files are:
      /opt/homebrew/Cellar/ghidra/11.3.2/Ghidra/Features/FileFormats/data/sevenzipnativelibs/Mac-x86_64/lib7-Zip-JBinding.dylib	(x86_64)

All for good reason:

  • Line cannot really be wrapped (can it?)
  • nsa blocks bot requests, I'm guessing
  • url-version order is reversed because of variable interpolation.

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. new formula PR adds a new formula to Homebrew/homebrew-core java Java use is a significant feature of the PR or issue labels Jun 12, 2025
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@Tokarak
Copy link
Author

Tokarak commented Jun 12, 2025

Things I'm not sure about:

  • I don't fully understand the test case. Why is it touching what seems like a java cache outside the CWD?
  • Is there a conflict with the ghidra cask? Should it be resolved by renaming the executable to "ghidra", or by declaring a conflict?
  • What's the homebrew stance on runtime java dependency? Is it really necessary to hard-code a 400mb dependency to a specific implementation and version of the JDK?
  • Ghidra/application.properties also has information about the JDK version used to compile Ghidra; I wasn't sure how to set it at runtime.
  • And, of course, I don't see how to fix the current CI failures without compromising something, as described in the main post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosquash Automatically squash pull request commits according to Homebrew style. java Java use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant