-
-
Notifications
You must be signed in to change notification settings - Fork 12.9k
tracy 0.12.1 #226073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
tracy 0.12.1 #226073
Conversation
What has happened to this update?
I compiled this version on Linux, macOS and Windows 🤔 |
Log says: -- CPM: Adding package [email protected] (v1.5.7 to /private/tmp/tracy-20250610-5786-xqwecw/tracy-0.12.1/capture/build/.cpm-cache/zstd/dfd2e0b6e613dcf44911302708e636a8aee527d2)
CMake Error at /opt/homebrew/Library/Homebrew/cmake/trap_fetchcontent_provider.cmake:12 (message):
Refusing to populate dependency 'zstd' with FetchContent while building in
Homebrew, please use a formula dependency or add a resource to the formula.
Call Stack (most recent call first):
/opt/homebrew/opt/cmake/share/cmake/Modules/FetchContent.cmake:2468:EVAL:1 (trap_fetchcontent_provider)
/opt/homebrew/opt/cmake/share/cmake/Modules/FetchContent.cmake:2468 (cmake_language)
/opt/homebrew/opt/cmake/share/cmake/Modules/FetchContent.cmake:2314 (__FetchContent_MakeAvailable_eval_code)
/private/tmp/tracy-20250610-57[86](https://github.com/Homebrew/homebrew-core/actions/runs/15559795771/job/43809592077?pr=226073#step:3:87)-xqwecw/tracy-0.12.1/cmake/CPM.cmake:1114 (FetchContent_MakeAvailable)
/private/tmp/tracy-20250610-5786-xqwecw/tracy-0.12.1/cmake/CPM.cmake:895 (cpm_fetch_package)
/private/tmp/tracy-20250610-5786-xqwecw/tracy-0.12.1/cmake/vendor.cmake:106 (CPMAddPackage)
CMakeLists.txt:17 (include) |
@SMillerDev I investigated the changes https://github.com/wolfpld/tracy/blob/master/cmake/vendor.cmake csvexport requires zstd, nfd and ppqsort (as I see) wolfpld/tracy@v0.11.1...v0.12.1 https://github.com/wolfpld/tracy/blob/master/cmake/vendor.cmake These requirements are new CPMAddPackage( CPMAddPackage( CPMAddPackage( CPMAddPackage( CPMAddPackage( But zstd was added 🤔
|
Yeah, somehow they forgot to make that one check for a system install. Would you mind filing an issue for that @gav2xlin ? |
@SMillerDev I doubt that this fix requires an issue -- CPM: Adding package [email protected] (v1.5.7 to /private/tmp/tracy-20250610-5786-xqwecw/tracy-0.12.1/capture/build/.cpm-cache/zstd/dfd2e0b6e613dcf44911302708e636a8aee527d2) option(HOMEBREW_ALLOW_FETCHCONTENT "Allow FetchContent to be used in Homebrew builds" OFF) if (HOMEBREW_ALLOW_FETCHCONTENT) macro(trap_fetchcontent_provider method depName) That's not difficult to fix https://cmake.org/cmake/help/latest/module/FetchContent.html#variable:FETCHCONTENT_FULLY_DISCONNECTED |
The problem here is that their CMake configuration checks for every dependency if it's on the system already. If it is not, it'll download it. Except for zstd where it does not check the system first. Homebrew doesn't want any dependencies downloading during the install stage so it blocks that. The fix would be for upstream to check if zstd is installed and only download it if it isn't. |
I found such workarounds in Homebrew -DHOMEBREW_ALLOW_FETCHCONTENT=ON - allow FetchContent() |
It should really be fixed upstream instead, because Homebrew won't be the only packager objecting to random downloads. |
@SMillerDev I doubt they will fix it. That's not a bug. Tracy depends on CPM.cmake I'm not a Ruby developer. I just copied examples from Homebrew. It was my first experiment https://github.com/Homebrew/homebrew-core/actions/runs/15774527360/job/44466317732?pr=227617
https://github.com/cpm-cmake/CPM.cmake/blob/master/cmake/CPM.cmake Then, I disabled some CPM features https://github.com/Homebrew/homebrew-core/actions/runs/15775035077/job/44467668865?pr=227617 CPM: nfd not found via find_package(nfd 1.2.1) https://github.com/wolfpld/tracy/blob/master/cmake/vendor.cmake Someone needs to add nfd, pqsort and imgui to Homebrew🤔 https://github.com/ocornut/imgui My change: https://github.com/cpm-cmake/CPM.cmake CPM_USE_LOCAL_PACKAGES If the option CPM_LOCAL_PACKAGES_ONLY is set, CPM will emit an error if the dependency is not found locally. These options can also be set as environmental variables. CPM_DONT_UPDATE_MODULE_PATH # I guess this option may be removed |
Created by
brew bump
Created with
brew bump-formula-pr
.release notes
View the full release notes at https://github.com/wolfpld/tracy/releases/tag/v0.12.1.