-
-
Notifications
You must be signed in to change notification settings - Fork 12.9k
freeimage: apply Debian patches to unbundle libraries #220708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c6feab7
to
616b48a
Compare
616b48a
to
fdc7554
Compare
fdc7554
to
0ab9360
Compare
May need to rebuild dependents as our previous Linux patch modified the SONAME incorrectly so was using macOS naming rather than the Linux naming. |
55a7bce
to
d1be468
Compare
Have we tried streaming this patch? |
For Debian patches:
For Homebrew patches:
I was tempted to try to deprecate/remove formula but it is a dependency for multiple formulae that are maintained. Perhaps a fork will gain traction in the future that will allow us to switch. There is one used by T2 SDE (https://github.com/danoli3/FreeImage) that has CMake support for external libraries. However, not used by major distros so not worth consideration yet. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Similar patches are also applied in pretty much all Linux distros. Went with Debian's as easiest to apply multiple patches. The original source of unbundle patches is from Fedora but they are on a SVN revision so their latest patches won't apply.
For now just doing this on Linux as macOS will need additional work, i.e. requires updating our dylib patch and will need another OpenEXR patch.
EDIT: bundled libraries had issues on newer macOS so trying to unbundle now.