-
-
Notifications
You must be signed in to change notification settings - Fork 12.8k
opencl-icd-loader 2022.05.18 (new formula) #106164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
depends_on "opencl-headers" => [:build, :test] | ||
|
||
def install | ||
inreplace "loader/icd_platform.h", "\"/etc/", "\"#{etc}/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noting that I should probably should add a caveat similar to ocl-icd
(and add comment for inreplace
) as our directory doesn't match official specification. Sadly, opencl-icd-loader
is less friendly to using non-standard location and requires modifying code rather than allowing config-time option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can just copy the caveat from ocl-icd
as it's basically the same.
As for the inreplace
, this is certainly not the only formula where we have to replace hard-coded prefixes so I think as long as it's explained it should be okay.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
f128dce
to
acf28a8
Compare
acf28a8
to
541ff05
Compare
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?Cherry-picked from #103141