Skip to content

opencl-icd-loader 2022.05.18 (new formula) #106164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Jul 19, 2022

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Cherry-picked from #103141

@cho-m cho-m added the new formula PR adds a new formula to Homebrew/homebrew-core label Jul 19, 2022
@cho-m cho-m mentioned this pull request Jul 19, 2022
6 tasks
depends_on "opencl-headers" => [:build, :test]

def install
inreplace "loader/icd_platform.h", "\"/etc/", "\"#{etc}/"
Copy link
Member Author

@cho-m cho-m Jul 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that I should probably should add a caveat similar to ocl-icd (and add comment for inreplace) as our directory doesn't match official specification. Sadly, opencl-icd-loader is less friendly to using non-standard location and requires modifying code rather than allowing config-time option.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just copy the caveat from ocl-icd as it's basically the same.

As for the inreplace, this is certainly not the only formula where we have to replace hard-coded prefixes so I think as long as it's explained it should be okay.

@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Aug 10, 2022
@cho-m cho-m removed the stale No recent activity label Aug 10, 2022
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Aug 31, 2022
@cho-m cho-m added in progress Stale bot should stay away and removed stale No recent activity labels Sep 2, 2022
@cho-m cho-m removed the in progress Stale bot should stay away label Sep 15, 2022
@cho-m cho-m added the ready to merge PR can be merged once CI is green label Sep 20, 2022
@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@cho-m cho-m deleted the opencl-icd-loader branch December 21, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new formula PR adds a new formula to Homebrew/homebrew-core ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants