Skip to content

New cask "ghidra", version 9.0_PUBLIC_20190228 #59872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 6, 2019
Merged

New cask "ghidra", version 9.0_PUBLIC_20190228 #59872

merged 5 commits into from
Apr 6, 2019

Conversation

Kreeblah
Copy link
Contributor

@Kreeblah Kreeblah commented Mar 6, 2019

This is a cask for installing Ghidra from https://www.ghidra-sre.org/.
Ghidra is a new reverse-engineering/decompilation tool, which the NSA
is in the process of open-sourcing. Since the source is not yet
available, caution is advised due to the source of the software.

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.
  • The submission is for a stable version or documented exception.

Additionally, if adding a new cask:

This is a cask for installing Ghidra from https://www.ghidra-sre.org/.
Ghidra is a new reverse-engineering/decompilation tool, which the NSA
is in the process of open-sourcing.  Since the source is not yet
available, caution is advised due to the source of the software.
@vitorgalvao
Copy link
Contributor

Since this will be a CLI-only open-source tool, please submit it first to Homebrew/core as a formula. Return here if not accepted (linking back to the pull request where it was refused).

This policy is documented in faq/rejected_casks:

The app is both open-source and CLI-only (i.e. it only uses the binary artifact). In that case, and in the spirit of deduplication, submit it first to Homebrew/core as a formula that builds from source. If it is rejected, you may then try again as a cask (link us to the issue so we can see the discussion and reasoning for rejection).

@vitorgalvao vitorgalvao closed this Mar 6, 2019
@Amar1729
Copy link
Contributor

Amar1729 commented Mar 8, 2019

FWIW, this is actually NOT a CLI-only tool. It's a bit odd, but the zip file is a static structure of an entire application. On *nix, running ghidraRun runs a support script that launches the (java) Ghidra application (while ghidraRun.bat does the same on Windows).

That said I don't know how you feel about including it as a Cask, since there's no actual .app or .pkg that creates an actual mac application.

I made a really simple tap for it until upstream officially starts bundling the .app.

ghidra_9.0
├── Extensions/
├── GPL/
├── Ghidra/
├── LICENSE.txt
├── docs/
├── ghidraRun*
├── ghidraRun.bat
├── licenses/
├── server/
└── support/

7 directories, 3 files

@vitorgalvao
Copy link
Contributor

This has already been submitted to Homebrew/core.

@tomyun
Copy link
Contributor

tomyun commented Apr 3, 2019

Seems like it was not accepted to Homebrew/core at this time: Homebrew/homebrew-core#37656
Hope to see it in the cask soon.

@vitorgalvao vitorgalvao reopened this Apr 3, 2019
@vitorgalvao
Copy link
Contributor

It seems the symlink source '/usr/local/Caskroom/ghidra/9.0.1_PUBLIC_20190325/ghidra_9.0/ghidraRun' is not there.

How to fix.

@Amar1729
Copy link
Contributor

Amar1729 commented Apr 4, 2019

fwiw, a lot of code was just added to the ghidra github repo in the past few days. seems to include build files.

@axeII
Copy link

axeII commented Apr 6, 2019

Any update on this? Ghidra source code has been already released.

@vitorgalvao vitorgalvao merged commit 102ebc4 into Homebrew:master Apr 6, 2019
@lock lock bot added the outdated label May 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants