Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trilium-notes: deprecate #207745

Merged
merged 1 commit into from
Apr 6, 2025
Merged

trilium-notes: deprecate #207745

merged 1 commit into from
Apr 6, 2025

Conversation

CoryKrol
Copy link
Contributor

@CoryKrol CoryKrol commented Apr 5, 2025

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@krehel
Copy link
Member

krehel commented Apr 5, 2025

Hi @CoryKrol - thanks for the PR - can you remove the extra commits for triliumnext-notes and squash this to a single commit targeting trilium-notes? Thanks!

@krehel krehel added the awaiting user reply Issue needs response from a user. label Apr 6, 2025
@khipp khipp changed the title trilium-notes: mark deprecated triliumnext-notes 0.92.4 (new cask) Apr 6, 2025
@khipp khipp changed the title triliumnext-notes 0.92.4 (new cask) trilium-notes: deprecate Apr 6, 2025
@khipp khipp removed the awaiting user reply Issue needs response from a user. label Apr 6, 2025
@krehel krehel added this pull request to the merge queue Apr 6, 2025
Merged via the queue into Homebrew:master with commit 8b27fd6 Apr 6, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cask deprecated Cask deprecated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants