Skip to content

fix: Wrong strip logic: SEQ segments get stripped to EQ #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 24, 2025
Merged

fix: Wrong strip logic: SEQ segments get stripped to EQ #78

merged 6 commits into from
Jan 24, 2025

Conversation

lord-haffi
Copy link
Collaborator

Review and merge #77 first.

@lord-haffi lord-haffi self-assigned this Jan 24, 2025
@hf-kklein hf-kklein changed the base branch from main to true_frozen January 24, 2025 14:13
hf-kklein
hf-kklein approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@hf-kklein hf-kklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Magst du kommentieren im Code was der Unterschied zu lstrip und rstrip aus der std lib ist?

@lord-haffi lord-haffi mentioned this pull request Jan 24, 2025
Merged
@lord-haffi
Copy link
Collaborator Author

Magst du kommentieren im Code was der Unterschied zu lstrip und rstrip aus der std lib ist?

Meinst du echt, ich soll Funktionalität von std lib Funktionen im Code hinterlegen? ^^ Falls du's nicht wusstest: Die strip-Funktionen aus der std lib, behandeln das Argument als Collection von characters, das heißt, dass .strip("abc") äquivalent zu .strip("cab") ist und links und rechts nacheinander die jeweiligen Zeichen wegnimmt.

Base automatically changed from true_frozen to main January 24, 2025 16:46
@lord-haffi lord-haffi enabled auto-merge (squash) January 24, 2025 16:48
@lord-haffi lord-haffi merged commit b6966a9 into main Jan 24, 2025
18 checks passed
@lord-haffi lord-haffi deleted the fix_prefix_strip branch January 24, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hf-kklein hf-kklein hf-kklein approved these changes

@DeltaDaniel DeltaDaniel Awaiting requested review from DeltaDaniel

Assignees

@lord-haffi lord-haffi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lord-haffi @hf-kklein @DeltaDaniel