feat: Support <Uebertragungsdatei> in AhbReader (adds flag is_on_uebertragungsdatei_level to AHB Segment model)
#132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add flag to `Segment` model
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the flag in the AhbReader by introducing a new boolean field in the Segment model and propagating its value through different layers. Key changes include:
- Adding the "is_on_uebertragungsdatei_level" flag to the SQL and Pydantic models.
- Updating the AhbReader to correctly set the flag during recursive processing.
- Introducing a new unit test to verify the flag’s behavior.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| unittests/test_ahb_serialisierung.py | Added a test function to validate the value of is_on_uebertragungsdatei_level for segments. |
| src/fundamend/sqlmodels/anwendungshandbuch.py | Introduced a new boolean field in the Segment SQLModel and updated model conversion functions. |
| src/fundamend/reader/ahbreader.py | Modified helper functions to pass the uebertragungsdatei flag into segment processing recursively. |
| src/fundamend/models/anwendungshandbuch.py | Updated the Pydantic model to include the new flag with a default value of False. |
| @@ -184,6 +184,7 @@ class Segment(SQLModel, table=True): | |||
| name: str = Field(index=True) #: e.g. 'Beginn der Nachricht' | |||
| number: str = Field(index=True) #: e.g. '00002' | |||
| ahb_status: str | None #: e.g. 'Muss' | |||
| is_on_uebertragungsdatei_level: bool | |||
There was a problem hiding this comment.
[nitpick] Consider providing a default value (e.g., False) for is_on_uebertragungsdatei_level to prevent potential issues when new Segment records are created without explicitly setting this field.
Suggested change
| is_on_uebertragungsdatei_level: bool | |
| is_on_uebertragungsdatei_level: bool = Field(default=False) |
Copilot uses AI. Check for mistakes.
hf-kklein
changed the title
<Uebertragungsdatei> in AhbReader<Uebertragungsdatei> in AhbReader (adds flag is_on_uebertragungsdatei_level to Segment model)
hf-kklein
changed the title
<Uebertragungsdatei> in AhbReader (adds flag is_on_uebertragungsdatei_level to Segment model)<Uebertragungsdatei> in AhbReader (adds flag is_on_uebertragungsdatei_level to AHB Segment model)
DeltaDaniel
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for MIG see #133