feat: Support <Uebertragungsdatei> in MigReader (.read() now returns either MessageImplementationGuide or Uebertragungsdatei w/ 1 nested MIG)
#130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
but not in AHBs yet; one step at a time
hf-kklein
changed the title
<Uebertragungsdatei> in MigReader<Uebertragungsdatei> in MigReader (.read() now returns either MessageImplementationGuide or Uebertragungsdatei w/ 1 nested MIG)
hf-kklein
added a commit
that referenced
this pull request
Apr 24, 2025
…_uebertragungsdatei_level` to MIG `Segment` model) (#133) feat: Support `<Uebertragungsdatei>` in `MigReader` (adds flag is_on_uebertragungsdatei_level to Segment model) We decided AGAINST modeling this as an extra level in our data model because it adds no value and makes the models less uniform than they are right now (see e.g. PR #130 ). This is because some MIGs do contain an Übertragungsdatei on root level, some don't and the distinction is more pain than the value gained (at least for our usecases). Feel free to report back in issues if this doesn't suit your needs.
|
done less intrusive in #133 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there is a simpler, less breaking alternative: #133
but not in AHBs yet; one step at a time
siehe auch: #57 (comment)