feat: join v_ahbesser with newly introduced ahb_expressions table
#125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf-kklein
commented
Apr 15, 2025
There was a problem hiding this comment.
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
Files not reviewed (2)
- src/fundamend/sqlmodels/create_ahbtabellen_view.sql: Language not supported
- unittests/snapshots/test_ahbesser_view.ambr: Language not supported
Comments suppressed due to low confidence (1)
src/fundamend/sqlmodels/ahbtabellen_view.py:45
- [nitpick] Consider renaming the field 'format' to avoid potential conflicts with Python's built-in 'format' function.
format: EdifactFormat = Field()
hf-kklein
commented
Apr 15, 2025
Comment on lines
+26
to
27
| create_and_fill_ahb_expression_table(session) | ||
| create_ahbtabellen_view(session) |
There was a problem hiding this comment.
man könnte es auch reinziehen in die create_ahbtabellen_view aber so ist es 1 python command für 1 SQL-"Ding" (wobei Ding = "Table" oder "View")
hf-kklein
commented
Apr 15, 2025
There was a problem hiding this comment.
der snapshot zeigt, womit du rechnen kannst.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.