Skip to content

feat: Add view v_ahbtabellen on top of ahb_hierarchy_materialized #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 14, 2025
Merged

feat: Add view v_ahbtabellen on top of ahb_hierarchy_materialized #118

merged 6 commits into from
Apr 14, 2025

Conversation

hf-kklein
Copy link
Contributor

No description provided.

feat: Add view v_ahbesser on top of ahb_hierarchy_materialized
6fa200e 
better typing

more docs

add snapshot

more docs 2
hf-kklein
hf-kklein commented Apr 14, 2025
View reviewed changes
unittests/__snapshots__/test_ahbesser_view.ambr Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hf-krechan check mal, was dir hier fehlt oder was nicht stimmt. die bedingungsspalte lösen wir separat

hf-kklein
hf-kklein commented Apr 14, 2025
View reviewed changes
src/fundamend/sqlmodels/create_ahbesser_view.sql Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not for me :(
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but maybe I am holding it wrong

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you editing a table?

hf-krechan
hf-krechan reviewed Apr 14, 2025
View reviewed changes
src/fundamend/sqlmodels/ahbesser_view.py Outdated
)


class AhbesserLine(SQLModel, table=True):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

würde gerne das Naming auf AHB-Tabellen anpassen.

Suggested change
class AhbesserLine(SQLModel, table=True):
class AhbTabellenLine(SQLModel, table=True):

@hf-kklein hf-kklein marked this pull request as ready for review April 14, 2025 09:39
@hf-kklein hf-kklein merged commit a34adb0 into main Apr 14, 2025
18 checks passed
@hf-kklein hf-kklein deleted the ahbesser-view branch April 14, 2025 09:40
@hf-kklein hf-kklein changed the title feat: Add view v_ahbesser on top of ahb_hierarchy_materialized feat: Add view v_ahbtabellen on top of ahb_hierarchy_materialized Apr 14, 2025
@hf-krechan hf-krechan linked an issue Apr 14, 2025 that may be closed by this pull request
Create another view that represents the kohlrahbi flatahb #115
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hf-krechan hf-krechan hf-krechan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create another view that represents the kohlrahbi flatahb
2 participants
@hf-kklein @hf-krechan