feat(cache): Add Memory Caching In Format Versions Endpoint #559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf-krechan
changed the title
hf-aschloegl
approved these changes
Apr 28, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds memory caching to the endpoint that returns format versions, improving performance by reducing repetitive database lookups. Key changes include:
- Introducing an in-memory cache with an expiration mechanism in the repository.
- Incorporating HTTP caching headers, including Cache-Control and ETag, in the controller response.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/server/repository/formatVersion.ts | Added memory caching for format versions with a TTL check |
| src/server/controller/formatVersion.ts | Added HTTP cache headers and an ETag based on the list content |
Comment on lines
+16
to
+17
| .setHeader('ETag', `"${formatVersionEntity.join(',')}"`) // Simple ETag based on content | ||
| .send(formatVersionEntity); |
There was a problem hiding this comment.
The current ETag generation concatenates version strings using commas, which may lead to collisions if any version string contains a comma. Consider using a hash function to create a more robust and unique ETag.
Suggested change
| .setHeader('ETag', `"${formatVersionEntity.join(',')}"`) // Simple ETag based on content | |
| .send(formatVersionEntity); | |
| .setHeader('ETag', `"${this.generateETag(formatVersionEntity)}"`) // Robust ETag using hash function |
Copilot uses AI. Check for mistakes.
hf-kklein
added a commit
that referenced
this pull request
Apr 29, 2025
…ited SQLite table (not the `v_ahbtabellen` view) (#562) * update database https://github.com/Hochfrequenz/xml-migs-and-ahbs/releases/tag/v2025.04.12.9z * Revert "feat(cache): Add Memory Caching In Format Versions Endpoint (#559)" This reverts commit b56ec4b. * read format version from Anwendungshandbuch tabelle fixes Hochfrequenz/xml-fundamend-python#137 fixes #560 * better * better docs * prettier --------- Co-authored-by: Konstantin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.