Skip to content

style: Make table head sticky #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 18, 2025
Merged

style: Make table head sticky #454

merged 7 commits into from
Feb 18, 2025

Conversation

hf-krechan
Copy link
Collaborator

No description provided.

The key was to:
Create a proper flex layout with h-screen to ensure full height
Use flex-none for header and footer to keep them fixed size
Make the content area overflow-auto with relative positioning
Apply sticky directly to the table header cells with top-0
@hf-krechan hf-krechan changed the title Make table head sticky style: Make table head sticky Feb 18, 2025
@github-actions github-actions bot added the style label Feb 18, 2025
Copy link
Contributor

@hf-kklein hf-kklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Ändert aber auch Farben, mindestens im Footer

@hf-krechan
Copy link
Collaborator Author

stimmt, habe eben erst gesehen dass es wohl weiß sein soll und nicht das offset weiß

@hf-krechan hf-krechan merged commit 306230a into main Feb 18, 2025
3 of 4 checks passed
@hf-krechan hf-krechan deleted the make-table-head-sticky branch February 18, 2025 18:12
@hf-kklein
Copy link
Contributor

Dachte nur, dass so oft wie die Farbe in den Vorgaben schon gewechselt hat, ist es leichter zu reverten wenn 1PR = 1 Change ;) meine Erfahrung zumindest.

Wenn jetzt nächste Woche der footer doch nicht mehr fixed ist, muss man beim revert noch an das offwhite denken.

@hf-krechan hf-krechan linked an issue Feb 18, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrollverhalten anpassen
2 participants