Skip to content

Feature: Adds test for login, logout, forgot-password and reset-password #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 12, 2025

Conversation

jakob-info
Copy link
Contributor

@jakob-info jakob-info commented May 8, 2025

Fixes #540, fixes #542, fixes #543.
Implements feature tests for api routes:

  • /auth/login
  • /auth/logout
  • /auth/register
  • /auth/forgot-password
  • /reset.password/{reset_token} (get and post)

I chose not to validate if the jwt token is correct. In my opinion, PHPUnit tests are for that.
I chose to duplicate some code and split the assertions in two tests because i didn't want the test function name to get too long because it tests different functionality.

  • I have read the contributing guidelines.
  • My code is of good quality and follows the coding standards of the project.
  • I have tested my changes, and they work as expected.

Thank you for your contribution! 🎉

@daveearley
Copy link
Contributor

Nice! Thank you very much for these changes

@daveearley daveearley merged commit 3e4a4f5 into HiEventsDev:develop May 12, 2025
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants