Fix/sass deprecation warnings #523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! I'll test and merge this soon. Much appreciated |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sass legacy JS API
The API is used by vite. Vite 5.4 has a config option to enable sass's new API. That fixes that issue. To achive this the minor version of dev dependencies got bumped. Minor versions do not include breaking changes.
Sass @import rule
The syntax for
@import "mixins"in all .scss files got changed. Additionally the old global built-in functionsmap-has-key()andmap-get()got replaced withmap.has-key()andmap.get(). Moreover, all rules likedisplay: blockhave to be at the top when using nesting to obide vanilla css rules.Fixes #522.
Checklist
Thank you for your contribution! 🎉
P. S. Consider a bot that automatically updates minor versions