Skip to content

feat: Complete the French (Français) translation of Puter #975 #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 21, 2024

Conversation

HatemLamia
Copy link
Contributor

Completed the French translations of Puter #975

@CLAassistant
Copy link

CLAassistant commented Dec 9, 2024

CLA assistant check
All committers have signed the CLA.

@jelveh
Copy link
Contributor

jelveh commented Dec 9, 2024

Hey @HatemLamia, thank you for you contribution.
I use AI to quality-check translation. Here's Claude told me:

A few suggested improvements:

"billing.upgrade_to_pro" uses "%strong%" awkwardly - consider "Passer à la version %strong%" instead
"billing.apps_and_games" - "Jeux" should be lowercase when following "&"
"billing.cancel_it"/"billing.keep_it" - "L'/Le" pronouns feel unnatural, simply use "Annuler"/"Garder"
"billing.accelerated" - "Optimisé" might be more appropriate than "Accéléré" in a business context

Otherwise, the translations maintain consistent tone and terminology throughout the billing interface context.

Is any of this something we should look into?

@HatemLamia
Copy link
Contributor Author

Hi @jelveh,
Could you please review my pull request? Thank you!

@jelveh jelveh merged commit 770b957 into HeyPuter:main Dec 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants