[Tech] Download helper binaries instead of storing them in the repo #3849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CommandMC
requested review from
a team,
arielj,
flavioislima,
Etaash-mathamsetty,
Nocccer and
imLinguin
and removed request for
a team
CommandMC
force-pushed
the
tech/binary-download
branch
from
80a60ea to
5d19d50
Compare
arielj
reviewed
Jul 15, 2024
arielj
approved these changes
Jul 15, 2024
We can simply tell it to unpack everything in the `bin` folder, since we already only include the binaries we need We can also use glob patters for the `files` option to include binaries for all architectures. Ideally we should figure out a way to only include the files for the arch we're building, but I don't think EB has an option for that
CommandMC
force-pushed
the
tech/binary-download
branch
from
17f7103 to
5061abe
Compare
flavioislima
approved these changes
Jul 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storing Legendary, gogdl, and Nile in this repo directly meant that updating them increases the size of our
.gitfolder substantially. This is not a sustainable solution.Instead, we now download them from GitHub, using
nightly.linkas a middle-man (to avoid authenticating). Subsequently, the current binaries were deleted.Where exactly the binaries come from is tracked using a run ID stored in the update script (
meta/downloadHelperBinaries.ts). Thus, changing this is as easy as changing that ID & re-runningpnpm download-helper-binaries.The current workflow run IDs point to the latest ones available in their respective repositories. As such, this PR updates Legendary and gogdl (resolving issues with EA app detection and repeated "Galaxy Common Redistributables" downloads).
You will have to runBinaries are also automatically re-downloaded when checking out branches, provided they changedpnpm download-helper-binariesmanually when testing this PR / after it's merged, as well as every time the run ID changes. I opted for not doing this automatically to lessen the load onnightly.link, as the script currently does not check whether the binaries have actually changed (a follow-up PR might change this).Heroic will now also use different binaries depending on your CPU architecture (with x86_64 and arm64 being the supported options). Currently the only platform with arm64 binaries is macOS, but Windows and Linux binaries can be easily added in the future
Closes #3846
Closes #3833
Use the following Checklist if you have changed something on the Backend or Frontend: